Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 2 | Data Groups#1131
Open
Darkidd77 wants to merge 6 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 2 | Data Groups#1131Darkidd77 wants to merge 6 commits intoCodeYourFuture:mainfrom
Darkidd77 wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
…ments for clarity
…ry-currency pairs
…s; implement tally function with error handling and corresponding tests
…omprehensive tests for various cases in invert.test.js. Create countWords function to count word occurrences in a string; add corresponding tests in count-words.test.js.
This comment has been minimized.
This comment has been minimized.
Darkidd77
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
…ing me to commit ann make my pr
Darkidd77
added
the
Needs Review
cjyuan
reviewed
Apr 2, 2026
Comment on lines
+47
to
+54
| // Given invalid parameters like an array | ||
| // When passed to contains | ||
| // Then it should return false or throw an error | ||
| test("contains returns false for invalid parameters", () => { | ||
| const arr = [1, 2, 3]; | ||
| expect(contains(arr, "a")).toEqual(false); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
This test cannot not yet confirm that the function correctly returns false when the first argument is an array.
This is because contains([1, 2, 3], "a") could also return false simply because "a" is not a key of the array.
Arrays are objects, with their indices acting as keys. A proper test should use a valid
key to ensure the function returns false specifically because the input is an array, not because the key is missing.
In addition, does your function behave as expected when the first argument is null or undefined?
Comment on lines
+6
to
+14
| const counts = {}; | ||
|
|
||
| for (const item of list) { | ||
| if (counts[item]) { | ||
| counts[item] = counts[item] + 1; | ||
| } else { | ||
| counts[item] = 1; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Does the following function call returns the value you expect?
tally(["toString", "toString"]);
Suggestion: Look up an approach to create an empty object with no inherited properties.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist:
Completed the tasks per instructions.